Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bug in importTracker: getExportNode must verify that we are on the LHS of a VariableDeclaration #17205

Merged
1 commit merged into from
Jul 17, 2017

Conversation

ghost
Copy link

@ghost ghost commented Jul 14, 2017

Previously this test would have crashed because we assume that symbol.parent will always be set on an exported VariableDeclaration, but weren't checking that we were at the LHS symbol.

@ghost ghost requested a review from aozgaa July 14, 2017 18:52
@ghost ghost force-pushed the findAllRefsExportConstEqualToClass branch from ed45342 to 30f83c5 Compare July 14, 2017 18:52
Copy link
Member

@sheetalkamat sheetalkamat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Leave a comment

@ghost ghost merged commit 6cf30fb into master Jul 17, 2017
@ghost ghost deleted the findAllRefsExportConstEqualToClass branch July 17, 2017 19:29
@microsoft microsoft locked and limited conversation to collaborators Jun 14, 2018
This pull request was closed.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants